[ 
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780292#comment-17780292
 ] 

Matthias Pohl edited comment on FLINK-33376 at 10/27/23 9:58 AM:
-----------------------------------------------------------------

Thanks for bringing this up. About your proposal: Keep in mind that there's a 
default charset defined in Flink (see 
[ConfigConstants#1767|https://github.com/apache/flink/blob/1354d2fae3fde2a448ce1fac5dee7859973a93e1/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java#L1767])
 which we might want to use here.

AFAIU, it would require a new configuration parameter, wouldn't it? If that's 
the case we might want to trigger a discussion on the dev ML (since 
configuration parameters are public API). I understand that we didn't do this 
in FLINK-31780. I just want to follow the process properly this time.

On another note: Are you interested in picking this issue up and driving it?


was (Author: mapohl):
Thanks for bringing this up. About your proposal: Keep in mind that there's a 
default charset defined in Flink (see 
[ConfigConstants#1767|https://github.com/apache/flink/blob/1354d2fae3fde2a448ce1fac5dee7859973a93e1/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java#L1767])
 which we might want to use here.

AFAIU, it would require a new configuration parameter, wouldn't it? If that's 
the case we might want to trigger a discussion on the dev ML (since 
configuration parameters are public API). I understand that we didn't do this 
in FLINK-31780. I just want to follow the process properly this time.

On another note: Are you interested in picking this issue up and driving it?

> Add AuthInfo config option for Zookeeper configuration
> ------------------------------------------------------
>
>                 Key: FLINK-33376
>                 URL: https://issues.apache.org/jira/browse/FLINK-33376
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Oleksandr Nitavskyi
>            Priority: Major
>
> In certain cases ZooKeeper requires additional Authentication information. 
> For example list of valid [names for 
> ensemble|https://zookeeper.apache.org/doc/r3.8.0/zookeeperAdmin.html#:~:text=for%20secure%20authentication.-,zookeeper.ensembleAuthName,-%3A%20(Java%20system%20property]
>  in order to prevent the accidental connecting to a wrong ensemble.
> Curator allows to add additional AuthInfo object for such configuration. Thus 
> it would be useful to add one more additional Map property which would allow 
> to pass AuthInfo objects during Curator client creation.
> *Acceptance Criteria:* For Flink users it is possible to configure auth info 
> list for Curator framework client.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to