1996fanrui commented on code in PR #691:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1372500366
##########
flink-autoscaler/pom.xml:
##########
@@ -31,6 +31,13 @@ under the License.
<name>Flink Autoscaler</name>
<packaging>jar</packaging>
+ <properties>
+ <surefire.module.config> <!-- required by
+ JobTopologyTest
+ -->--add-opens=java.base/java.lang=ALL-UNNAMED
+ </surefire.module.config>
Review Comment:
```suggestion
<!-- required by JobTopologyTest -->
<surefire.module.config>--add-opens=java.base/java.lang=ALL-UNNAMED</surefire.module.config>
```
How about this? It's easy to read.
##########
flink-kubernetes-operator/pom.xml:
##########
@@ -34,6 +34,10 @@ under the License.
<properties>
<awaitility.version>4.1.0</awaitility.version>
<plugins.tmp.dir>${project.build.directory}/plugins</plugins.tmp.dir>
+ <surefire.module.config> <!-- required by
+ FlinkConfigManagerTest
+ -->--add-opens=java.base/java.util=ALL-UNNAMED
+ </surefire.module.config>
Review Comment:
```suggestion
<!-- required by FlinkConfigManagerTest -->
<surefire.module.config> --add-opens=java.base/java.util=ALL-UNNAMED
</surefire.module.config>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
