tzulitai commented on code in PR #23555:
URL: https://github.com/apache/flink/pull/23555#discussion_r1370318341
##########
flink-core/src/main/java/org/apache/flink/api/connector/sink2/TwoPhaseCommittingSink.java:
##########
@@ -77,4 +97,42 @@ interface PrecommittingSinkWriter<InputT, CommT> extends
SinkWriter<InputT> {
*/
Collection<CommT> prepareCommit() throws IOException,
InterruptedException;
}
+
+ /** The interface exposes some runtime info for creating a {@link
Committer}. */
+ @PublicEvolving
+ interface CommitterInitContext {
Review Comment:
Is it possible to go with option 2 + deprecate the existing
`createWriter(InitContext)` method and have a new one
`createWriter(WriterInitContext)` + have a backwards compatible path for
existing implementors? In that case we should create a JIRA to keep track of
removing all these deprecations in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
