jeyhunkarimov opened a new pull request, #23586:
URL: https://github.com/apache/flink/pull/23586

   ## What is the purpose of the change
   
   This pull request fixes tests in `LookupJoinITCase`. The errors in tests 
occured when changing `registerFunction` to `createTemporaryFunction `. The 
main issue was that existing `UserDefinedFunctionTestUtils.TestAddWithOpen` 
class's `eval` method was enforcing `NOT NULL` on types, because `Int` and 
`Long` types cannot be null in `scala`. This was creating a discrepancy between 
table schema and the registered function. 
   
   ## Brief change log
   
     -  Add an extra method to  `UserDefinedFunctionTestUtils.TestAddWithOpen` 
to support `nullable` types 
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
`UserDefinedFunctionTestUtils`.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`:  no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to