mas-chen commented on PR #52: URL: https://github.com/apache/flink-connector-kafka/pull/52#issuecomment-1767427165
Thanks for explaining, the PR description was confusing and I thought the issue was that the Kafka API was returning -1 offset for empty partition. So basically, with this change, we should be storing the initial offset of 0 in these cases (would be good to add unit test with the new offset initializer that verifies this). I thought of an alternative solution on the reader side to set offsets to `consumer.position(tp) - 1` (I also realized this is how the old implementation handles it). But I guess you could have an edge case, in which your checkpoint starts before offsets are resolved by the reader... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
