Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2758#discussion_r86661415
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/sql/SqlITCase.java
---
@@ -118,4 +119,39 @@ public void testJoin() throws Exception {
String expected = "Hi,Hallo\n" + "Hello,Hallo Welt\n" + "Hello
world,Hallo Welt\n";
compareResultAsText(results, expected);
}
+
+
+ @Test
+ public void testLikeWithEscapeFromDataSet() throws Exception {
--- End diff --
We try to keep the number of integration tests for the Table API to a
minimum to not exceed Travis' build time threshold of 2 hours. I think we do
not need the IT cases, the `ScalarFunctionsTest` should cover all cases.
You can add new tests to `ScalarFunctionsTest` called `testLikeWithEscape`,
`testSimilarWithEscape` just like what `testLike` did.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
