Zakelly commented on code in PR #23347:
URL: https://github.com/apache/flink/pull/23347#discussion_r1357949989
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java:
##########
@@ -314,4 +317,28 @@ public class ExecutionCheckpointingOptions {
"Defines the maximum number of subtasks that share
the same channel state file. "
+ "It can reduce the number of small files
when enable unaligned checkpoint. "
+ "Each subtask will create a new channel
state file when this is configured to 1.");
+
+ public static final ConfigOption<ThreadDumpLogLevel>
+ THREAD_DUMP_LOG_LEVEL_WHEN_CHECKPOINT_TIMEOUT =
+
key("execution.checkpointing.thread-dump-log-level-when-checkpoint-timeout")
Review Comment:
That's a very good point. And is it meaningful to define different log level
for different scenarios? Thus I prefer change the option name to
`execution.checkpointing.thread-dump-log-level.checkpoint-expired`, and provide
different suffixes for various scenarios. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
