Zakelly commented on PR #23441: URL: https://github.com/apache/flink/pull/23441#issuecomment-1760741020
> Thanks for the pr! Changes about these comments LGTM. But I found some implementaion is not consistent. (See PartitionableListState#update, PartitionableListState#addAll,BatchExecutionKeyListState) > > I think we should also make them follow the comment, WDYT ? Good point, I added sanity check in those implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
