[ 
https://issues.apache.org/jira/browse/FLINK-33182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772592#comment-17772592
 ] 
lincoln lee commented on FLINK-33182:
-------------------------------------

[~twalthr] I've thought about this carefully, and for upsert sources, while the 
non-determinism of the metadata column doesn't affect the +U message, if there 
is a -D message, there is no guarantee of correctness if we relax the strict 
restriction on the metadata (since the metadata column in the -D message is 
carried by the message itself, not as the changelognormalize node is handled). 
So, if we want to relax the restriction, we need to additionally make sure that 
the source does not contain -D message, WDYT?

> Allow metadata columns in NduAnalyzer with ChangelogNormalize
> -------------------------------------------------------------
>
>                 Key: FLINK-33182
>                 URL: https://issues.apache.org/jira/browse/FLINK-33182
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>            Reporter: Timo Walther
>            Priority: Major
>
> Currently, the NduAnalyzer is very strict about metadata columns in updating 
> sources. However, for upsert sources (like Kafka) that contain an incomplete 
> changelog, the planner always adds a ChangelogNormalize node. 
> ChangelogNormalize will make sure that metadata columns can be considered 
> deterministic. So the NduAnalyzer should be satisfied in this case. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to