dawidwys commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1345519922
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -104,9 +104,16 @@ private ExecNodeContext(@Nullable Integer id, String name,
Integer version) {
@JsonCreator
public ExecNodeContext(String value) {
this.id = null;
- String[] split = value.split("_");
- this.name = split[0];
- this.version = Integer.valueOf(split[1]);
+ try {
+ String[] split = value.split("_");
+ this.name = split[0];
+ this.version = Integer.valueOf(split[1]);
+ } catch (Exception e) {
+ throw new TableException(
Review Comment:
Initially I also thought of just null checking. I went for `try catch`
instead of a null check, because theoretically there might be a few reasons for
an exception:
1. Error while splitting.. we don't have two parts
2. Error while parsing the Integer, the second part is not a number
3. Error while parsing the Integer, the part is a null
I understand 1 & 2 are unlikely atm, but I guess we thought the same about
the `null_null` situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
