XComp commented on code in PR #23415:
URL: https://github.com/apache/flink/pull/23415#discussion_r1345486880
##########
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalDriver.java:
##########
@@ -122,6 +125,19 @@ public void close() throws Exception {
client.getConnectionStateListenable().removeListener(connectionStateListener);
cache.close();
+
+ try {
+ if (client.getZookeeperClient().isConnected()
+ &&
!connectionInformationPath.contains(RESOURCE_MANAGER_NODE)) {
Review Comment:
@KarmaGYZ Sorry for jumping in that late. I was on vacation for the past
three weeks. I have a question about this change: Why do we have to filter the
ResourceManager node here? It feels odd to refer to the ResourceManager in the
`ZooKeeperLeaderRetrievalDriver`. Knowledge about the ResourceManager component
should be out-of-scope for the driver implementation. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
