xiangyuf commented on PR #23201: URL: https://github.com/apache/flink/pull/23201#issuecomment-1741939759
> Thanks for the PR, Xiangyu! I give it a first pass and left some comments. > > My major concern is that, place the resource allocation decisions related to the minimum resources in the SlotManager will increase the coupling between the SlotManager and ResourceAllocationStrategy. If we would implement a new ResourceAllocationStrategy for hetorogenous TM, the resource spec of TMs to fulfill min resouce restriction should be provided by that specific strategy. > > So, I think it make more sense to handing over the decision-making authority to `ResourceAllocationStrategy`. Maybe we can rename the `tryReleaseUnusedResources` to `tryReconcileClusterResources` and extend it capability to resource allocation as well. Also, we can rename the `checkTaskManagerReleasable` to `reconcileClusterResources`. > > cc @huwh @KarmaGYZ Resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
