dawidwys commented on code in PR #23223:
URL: https://github.com/apache/flink/pull/23223#discussion_r1339654177
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -777,6 +781,16 @@ protected void convertSelectImpl(final Blackboard bb,
SqlSelect select) {
if (select.hasHints()) {
final List<RelHint> hints = SqlUtil.getRelHint(hintStrategies,
select.getHints());
+ if (!hints.isEmpty()) {
Review Comment:
Can `hints` be empty if `select.hasHints` says `true` ? If not, how about we
move the config check before extracting the hints? It's unnecessary to go over
the `RelNode` if we know we will throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
