Tan-JiaLiang commented on PR #52: URL: https://github.com/apache/flink-connector-kafka/pull/52#issuecomment-1737250148
> Thanks for the patch! I do think that we should add an e2e test, say to `KafkaTableITCase` that follows the repro instructions in the issue: > > ``` > 1. Set up a Kafka topic with 10 partitions > 2. produce records 0-9 into the topic > 3. take a savepoint and stop the job > 4. produce records 10-19 into the topic > 5. restore the job from the savepoint. > ``` > > I think that we should add the test because otherwise there is no automatic way to verify that we do not accidentally reintroduce that issue again some time in the future. It will also speed up the review process since it will be easy to verify that the problem is fixed. For example, the e2e test fails on `main` and passes on this branch. > > Please let me know if you need a hand with developing that test. @Gerrrr Thanks for the code review, very useful suggestions. I have add test case in KafkaTableITCase#testLatestOffsetStrategyResume, please help to check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
