1996fanrui commented on code in PR #677:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1336584237
##########
flink-autoscaler/pom.xml:
##########
@@ -45,6 +45,32 @@ under the License.
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <version>${lombok.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- TODO FLINK-33098: These jackson dependencies can be replaced with
flink shaded jackson. It can be done
Review Comment:
The `flink-autoscaler` depends on the `flink-runtime 1.17.1`, and
`flink-runtime 1.17.1` depends on the `flink-shaded-jackson 2.13.4-16.1`.
If `flink-autoscaler` depends on the `flink-shaded-jackson 2.14.2-17.0`
directly, the `2.13.4-16.1` and `2.14.2-17.0` may be conflicted, right?
So here has 2 temporary solutions:
- Soluiton1: Using the unified jackson dependence of
`flink-kubernetes-operator` (Current PR is it.)
- Solution2: flink-autoscaler` depends on the `flink-shaded-jackson
2.14.2-17.0` directly, and exclude `flink-shaded-jackson` from `flink-runtime`.
In the short term, all of them are fine for me.
Hi @gyfora @mxm , you are the expert of `flink-kubernetes-operator`, could
the whole `flink-kubernetes-operator` use the `flink-shaded-jackson
2.14.2-17.0`?
If yes, this problem is easy to solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
