[GitHub] [flink] venkata91 commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

[via GitHub]

venkata91 commented on code in PR #23313:
URL: https://github.com/apache/flink/pull/23313#discussion_r1331904794


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##########
@@ -1183,7 +1194,9 @@ private Map<Map<String, String>, Collection<Row>> 
filterAllData(
                 for (Row row : allData.get(partition)) {
                     boolean isRetained =
                             
FilterUtils.isRetainedAfterApplyingFilterPredicates(
-                                    filterPredicates, getValueGetter(row));
+                                    filterPredicates,
+                                    getValueGetter(row),
+                                    Optional.of(getNestedValueGetter(row)));

Review Comment:
   I see the point around not passing `Optional` as method param. Let me try to 
fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org