[ 
https://issues.apache.org/jira/browse/FLINK-33013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764512#comment-17764512
 ] 

Jiabao Sun commented on FLINK-33013:
------------------------------------

Thanks [~ruanhang1993], it make sense to me.

As the [Externalized Connector 
development|https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development]
 says. 

Bundling of flink-connector-base
Connectors should not bundle the connector-base module from Flink and instead 
set it to provided, as contained classes may rely on internal Flink classes.

The flink-connector-base has been put into recent fink dist lib.
Closed this issue because we needn't shaded flink-connector-base into 
connectors any more.

> Shade flink-connector-base info flink-sql-connector-connector
> -------------------------------------------------------------
>
>                 Key: FLINK-33013
>                 URL: https://issues.apache.org/jira/browse/FLINK-33013
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / MongoDB
>    Affects Versions: mongodb-1.0.2
>            Reporter: Jiabao Sun
>            Priority: Major
>              Labels: pull-request-available
>
> Shade flink-connector-base info flink-sql-connector-connector



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to