Jiabao-Sun commented on code in PR #15:
URL:
https://github.com/apache/flink-connector-mongodb/pull/15#discussion_r1323965537
##########
flink-sql-connector-mongodb/pom.xml:
##########
@@ -60,6 +60,10 @@ under the License.
<artifactSet>
<includes>
<include>*:*</include>
+
<include>org.apache.flink:flink-connector-base</include>
+
<include>org.apache.flink:flink-connector-mongodb</include>
+
<include>org.mongodb:*</include>
+
<include>org.bson:*</include>
Review Comment:
Thanks @ruanhang1993 to remind me of this.
The old shaded package does not include `flink-connector-base` is that has
provided scope.
I removed the useless includes and it works.
Please help review it again when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
