mbalassi commented on code in PR #666:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/666#discussion_r1319796729
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -365,22 +365,45 @@ public static String operatorConfigKey(String key) {
.withDescription(
"Initial interval of automatic reconcile retries
on recoverable errors.");
+ @Documentation.Section(SECTION_SYSTEM)
+ public static final ConfigOption<Duration> OPERATOR_RETRY_MAX_INTERVAL =
+ operatorConfig("retry.max.interval")
+ .durationType()
+ .defaultValue(Duration.ZERO)
+ .withDescription(
+ "Max interval of automatic reconcile retries on
recoverable errors, if set to <=0, no limit is applied.");
+
@Documentation.Section(SECTION_SYSTEM)
public static final ConfigOption<Double>
OPERATOR_RETRY_INTERVAL_MULTIPLIER =
operatorConfig("retry.interval.multiplier")
.doubleType()
- .defaultValue(2.0)
+ .defaultValue(1.5)
.withDescription(
"Interval multiplier of automatic reconcile
retries on recoverable errors.");
@Documentation.Section(SECTION_SYSTEM)
public static final ConfigOption<Integer> OPERATOR_RETRY_MAX_ATTEMPTS =
operatorConfig("retry.max.attempts")
.intType()
- .defaultValue(10)
+ .defaultValue(15)
.withDescription(
"Max attempts of automatic reconcile retries on
recoverable errors.");
+ @Documentation.Section(SECTION_SYSTEM)
+ public static final ConfigOption<Duration> OPERATOR_RATE_LIMITER_PERIOD =
+ operatorConfig("rate-limiter.refresh-period")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(15))
+ .withDescription("Operator rate limiter refresh period for
each resource.");
+
+ @Documentation.Section(SECTION_SYSTEM)
+ public static final ConfigOption<Integer> OPERATOR_RATE_LIMITER_LIMIT =
+ operatorConfig("rate-limiter.limit")
+ .intType()
+ .defaultValue(5)
+ .withDescription(
+ "Max number of reconcile loops triggered in within
the rate limiter refresh period for each resource. Setting the limit <= 0
disables the limiter.");
Review Comment:
nit: `triggered within`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
