[ 
https://issues.apache.org/jira/browse/FLINK-33038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762248#comment-17762248
 ] 

xiaogang zhou edited comment on FLINK-33038 at 9/6/23 2:26 AM:
---------------------------------------------------------------

[~Sergey Nuyanzin]  fixed, would you please have a quick review?


was (Author: zhoujira86):
[~Sergey Nuyanzin] [https://github.com/apache/flink/pull/23360] fixed, would 
you please have a quick review?

> remove getMinRetentionTime in StreamExecDeduplicate
> ---------------------------------------------------
>
>                 Key: FLINK-33038
>                 URL: https://issues.apache.org/jira/browse/FLINK-33038
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>    Affects Versions: 1.18.0
>            Reporter: xiaogang zhou
>            Assignee: xiaogang zhou
>            Priority: Minor
>             Fix For: 1.19.0
>
>
> I suggest to remove the getMinRetentionTime method in StreamExecDeduplicate 
> as it is not called by anyone and the ttl is controlled by the state meta 
> data.
>  
> Please let me take the issue if possible



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to