zhangyy91 commented on code in PR #23265:
URL: https://github.com/apache/flink/pull/23265#discussion_r1314270221
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java:
##########
@@ -150,10 +147,11 @@ public void
testCancelAsyncProducerAndConsumer(@InjectMiniCluster MiniCluster fl
}
// Verify that async producer is in blocking request
- assertTrue(
- "Producer thread is not blocked: "
- +
Arrays.toString(ASYNC_PRODUCER_THREAD.getStackTrace()),
- producerBlocked);
+ assertThat(producerBlocked)
+ .withFailMessage(
Review Comment:
fixed
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerLocationTest.java:
##########
@@ -26,7 +26,7 @@
import java.net.InetAddress;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.junit.jupiter.api.Assertions.fail;
+import static org.assertj.core.api.Assertions.fail;
Review Comment:
fixed
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java:
##########
@@ -420,11 +408,11 @@ public void testFailWithWrappedException() throws
Exception {
task.run();
- assertEquals(ExecutionState.FAILED, task.getExecutionState());
- assertTrue(task.isCanceledOrFailed());
+ assertThat(task.getExecutionState()).isEqualTo(ExecutionState.FAILED);
+ assertThat(task.isCanceledOrFailed()).isTrue();
final Throwable cause = task.getFailureCause();
- assertTrue(cause instanceof IOException);
+ assertThat(cause instanceof IOException).isTrue();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
