asha-boyapati commented on PR #23298: URL: https://github.com/apache/flink/pull/23298#issuecomment-1704040989
I want to add that this PR not only removes flakiness from the test mentioned in the title and description (`org.apache.flink.runtime.state.FileStateBackendMigrationTest.testKeyedMapStateStateMigration`), but also from the following two tests: `org.apache.flink.runtime.state.FileStateBackendMigrationTest.testKeyedMapStateAsIs` and `org.apache.flink.runtime.state.FileStateBackendMigrationTest.testKeyedMapStateSerializerReconfiguration` All 3 tests call the function `testKeyedMapStateUpgrade`, which used to use unsorted iterators before this PR but uses sorted iterators after this PR. This PR thus removes the flakiness from all 3 tests in the same way. I confirmed this by checking out the versions just before and after this commit and running the NonDex tool using the following commands: `mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -DnondexRuns=10 -pl flink-runtime -Dtest=org.apache.flink.runtime.state.FileStateBackendMigrationTest#testKeyedMapStateStateMigration` `mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -DnondexRuns=10 -pl flink-runtime -Dtest=org.apache.flink.runtime.state.FileStateBackendMigrationTest#testKeyedMapStateAsIs` `mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -DnondexRuns=10 -pl flink-runtime -Dtest=org.apache.flink.runtime.state.FileStateBackendMigrationTest#testKeyedMapStateSerializerReconfiguration` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
