[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761219#comment-17761219 ]
Jane Chan commented on FLINK-31788: ----------------------------------- Sorry for just noticing this issue now. This problem should be a feature rollback when deprecating the old planner since 1.15. The method `emitUpdateWithRetract` was not called in the codegen, but the [user-defined table agg func doc|https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/dev/table/functions/udfs/#retraction-example] still gives the retract example that evaluates this method. {quote}Jark: I'm wondering why it is not found for so many years. Does it mean users rarely use it? {quote} IMO, we can evaluate whether users still need this feature versus the cost of fixing it. If we no longer intend to support this method, we can open a discussion to deprecate it. Alternatively, it's reasonable to add it back. > Add back Support emitValueWithRetract for TableAggregateFunction > ---------------------------------------------------------------- > > Key: FLINK-31788 > URL: https://issues.apache.org/jira/browse/FLINK-31788 > Project: Flink > Issue Type: Bug > Components: Table SQL / Planner > Reporter: Feng Jin > Priority: Major > > This feature was originally implemented in the old planner: > [https://github.com/apache/flink/pull/8550/files] > However, this feature was not implemented in the new planner , the Blink > planner. > With the removal of the old planner in version 1.14 > [https://github.com/apache/flink/pull/16080] , this code was also removed. > > We should add it back. > > origin discuss link: > https://lists.apache.org/thread/rnvw8k3636dqhdttpmf1c9colbpw9svp -- This message was sent by Atlassian Jira (v8.20.10#820010)