lindong28 commented on code in PR #23331:
URL: https://github.com/apache/flink/pull/23331#discussion_r1312412768
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointAfterAllTasksFinishedITCase.java:
##########
@@ -106,7 +113,7 @@ public void testRestoreAfterSomeTasksFinished() throws
Exception {
miniCluster,
jobGraph.getJobID(),
findVertexByName(jobGraph, "passA -> Sink: sinkA").getID(),
- false);
+ true);
Review Comment:
Can you explain why we need to make this change?
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointAfterAllTasksFinishedITCase.java:
##########
@@ -75,6 +76,12 @@ public void setUp() {
bigResult = sharedObjects.add(new CopyOnWriteArrayList<>());
}
+ @AfterEach
+ public void teardown() {
+ IntegerStreamSource.latch = null;
Review Comment:
Instead of setting this variable to `null` in tearDown() and initializing it
to `new CountDownLatch(1)` in the test, would it be simpler to just initialize
it to `new CountDownLatch(1)` in setUp()?
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointAfterAllTasksFinishedITCase.java:
##########
@@ -75,6 +76,12 @@ public void setUp() {
bigResult = sharedObjects.add(new CopyOnWriteArrayList<>());
}
+ @AfterEach
+ public void teardown() {
+ IntegerStreamSource.latch = null;
+ IntegerStreamSource.failedBefore = false;
Review Comment:
Would it make more sense move this statement to `setUp()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
