[GitHub] [flink] RocMarshal commented on a diff in pull request #23219: [FLINK-20681][yarn] Support specifying the hdfs path when ship archives or files

[via GitHub]

RocMarshal commented on code in PR #23219:
URL: https://github.com/apache/flink/pull/23219#discussion_r1305796291


##########
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java:
##########
@@ -565,7 +565,8 @@ void testShipFiles() throws Exception {
         YarnClusterDescriptor flinkYarnDescriptor =
                 (YarnClusterDescriptor) 
clientFactory.createClusterDescriptor(executorConfig);
 
-        
assertThat(flinkYarnDescriptor.getShipFiles()).isEqualTo(Lists.newArrayList(tmpFile));
+        assertThat(flinkYarnDescriptor.getShipFiles())
+                .isEqualTo(Lists.newArrayList(new 
org.apache.hadoop.fs.Path(tmpFile.toURI())));

Review Comment:
   ```suggestion
                   .containsExactly(new 
org.apache.hadoop.fs.Path(tmpFile.toURI()));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org