[GitHub] [flink] lsyldliu commented on a diff in pull request #23216: [FLINK-32831][table-planner] RuntimeFilterProgram should aware join type when looking for the build side

[via GitHub]

lsyldliu commented on code in PR #23216:
URL: https://github.com/apache/flink/pull/23216#discussion_r1305271659


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgram.java:
##########
@@ -601,7 +622,7 @@ private static boolean isSuitableDataSize(
         Optional<Double> probeSize = getEstimatedDataSize(probeSide);
 
         long maxBuildDataSize = getMaxBuildDataSize(buildSide);
-        long minProbeDataSize = getMaxBuildDataSize(buildSide);
+        long minProbeDataSize = getMinProbeDataSize(buildSide);

Review Comment:
   probeSide?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org