wangzzu commented on code in PR #23244:
URL: https://github.com/apache/flink/pull/23244#discussion_r1300834532
##########
flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java:
##########
@@ -628,19 +631,20 @@ public void
testOutOfMemoryErrorMessageEnrichmentInJobVertexFinalization() throw
try {
jobResultFuture.get().toJobExecutionResult(getClass().getClassLoader());
} catch (JobExecutionException e) {
- assertThat(e,
FlinkMatchers.containsCause(OutOfMemoryError.class));
+ assertThat(e)
+
.satisfies(matching(FlinkMatchers.containsCause(OutOfMemoryError.class)));
assertThat(
- findThrowable(e, OutOfMemoryError.class)
- .map(OutOfMemoryError::getMessage)
- .get(),
- startsWith(
- "Java heap space. A heap space-related
out-of-memory error has occurred."));
+ findThrowable(e, OutOfMemoryError.class)
+ .map(OutOfMemoryError::getMessage)
+ .get())
+ .startsWith(
+ "Java heap space. A heap space-related
out-of-memory error has occurred.");
Review Comment:
fixed
##########
flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java:
##########
@@ -593,12 +596,12 @@ public void testCallFinalizeOnMasterBeforeJobCompletes()
throws Exception {
jobResultFuture.get().toJobExecutionResult(getClass().getClassLoader());
- assertTrue(WaitOnFinalizeJobVertex.finalizedOnMaster.get());
+
assertThat(WaitOnFinalizeJobVertex.finalizedOnMaster.get()).isTrue();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
