wangzzu commented on code in PR #23242:
URL: https://github.com/apache/flink/pull/23242#discussion_r1300071546
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestServerEndpointITCase.java:
##########
@@ -340,60 +331,52 @@ public void testBadHandlerRequest() throws Exception {
} catch (ExecutionException ee) {
Throwable t = ExceptionUtils.stripExecutionException(ee);
- assertTrue(t instanceof RestClientException);
+ assertThat(t instanceof RestClientException).isTrue();
RestClientException rce = (RestClientException) t;
- assertEquals(HttpResponseStatus.BAD_REQUEST,
rce.getHttpResponseStatus());
+
assertThat(rce.getHttpResponseStatus()).isEqualTo(HttpResponseStatus.BAD_REQUEST);
Review Comment:
@Jiabao-Sun if we use `assertThatFuture`, how can we do the test for
`rce.getHttpResponseStatus()` witch is not a msg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
