wangzzu commented on PR #23227:
URL: https://github.com/apache/flink/pull/23227#issuecomment-1684110666

   > Thanks @wangzzu for the contribution, and @wangzzu for the review!
   > 
   > > Would you mind updating all change about these improvements?
   > > ```
   > > * Make test classes package-visible and do not extend JUnit4-based 
TestLogger
   > > 
   > > * Update isEqualTo(0) to isZero()
   > > 
   > > * Update isEqualTo(1) to isOne()
   > > ```
   > 
   > I still see a little `isEqualTo(0)` and `isEqualTo(1)`, could you search 
and fix them?
   
   @1996fanrui Thanks for your review, i have updated these and check globally 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to