XComp commented on code in PR #23229:
URL: https://github.com/apache/flink/pull/23229#discussion_r1297168003


##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/MultipartUploadExtension.java:
##########
@@ -119,6 +120,12 @@ public void before(ExtensionContext context) throws 
Exception {
         }
         file2 = TempDirUtils.newFile(tmpDirectory);
         Files.write(file2.toPath(), 
"world".getBytes(ConfigConstants.DEFAULT_CHARSET));
+        file3 = TempDirUtils.newFile(tmpDirectory);
+        try (RandomAccessFile rw = new RandomAccessFile(file3, "rw")) {
+            // magic value that reliably reproduced EndOfDataDecoderException 
in hasNext()
+            rw.setLength(1410);

Review Comment:
   The test doesn't fail on my machine if I revert the fix. That makes me 
believe that this magic value doesn't reproduce the scenario reliably. How did 
you come up with the test scenario? :thinking: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to