KarmaGYZ commented on code in PR #23231:
URL: https://github.com/apache/flink/pull/23231#discussion_r1297125240
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManagerFactory.java:
##########
@@ -109,17 +109,35 @@ protected ResourceManager<ResourceID>
createResourceManager(
* @return the configuration for standalone ResourceManager
*/
@VisibleForTesting
- public static Configuration getConfigurationWithoutMaxSlotNumberIfSet(
+ public static Configuration getConfigurationWithoutMaxResourceNumIfSet(
Review Comment:
```suggestion
public static Configuration getConfigurationWithoutMaxResourceIfSet(
```
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManagerFactory.java:
##########
@@ -109,17 +109,35 @@ protected ResourceManager<ResourceID>
createResourceManager(
* @return the configuration for standalone ResourceManager
*/
@VisibleForTesting
- public static Configuration getConfigurationWithoutMaxSlotNumberIfSet(
+ public static Configuration getConfigurationWithoutMaxResourceNumIfSet(
Configuration configuration) {
final Configuration copiedConfig = new Configuration(configuration);
- // The max slot limit should not take effect for standalone cluster,
we overwrite the
+ overwriteMaxResourceNumConfig(copiedConfig);
+
+ return copiedConfig;
+ }
+
+ private static void overwriteMaxResourceNumConfig(Configuration
configuration) {
Review Comment:
```suggestion
private static void removeMaxResourceConfig(Configuration configuration)
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
