Fanoid commented on code in PR #250:
URL: https://github.com/apache/flink-ml/pull/250#discussion_r1296795610
##########
flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/ListStateWithCache.java:
##########
@@ -62,14 +63,32 @@ public class ListStateWithCache<T> implements ListState<T> {
/** The data cache writer for the received records. */
private final DataCacheWriter<T> dataCacheWriter;
- @SuppressWarnings("unchecked")
public ListStateWithCache(
TypeSerializer<T> serializer,
StreamTask<?, ?> containingTask,
StreamingRuntimeContext runtimeContext,
StateInitializationContext stateInitializationContext,
OperatorID operatorID)
throws IOException {
+ this(
+ serializer,
+ containingTask,
+ runtimeContext,
+ stateInitializationContext,
+ operatorID,
+ 0.);
Review Comment:
@jiangxin369 and @zhipeng93 , thanks for your comments.
After offline discussion, I found it is necessary to do check about
sub-fractions from all usages on the operator-scope managed memory. So I
changed the constructor of `ListStateWithCache`.
Please check the latest changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
