Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295826480
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerAsyncTest.java:
##########
@@ -199,15 +199,15 @@ public void read() throws IOException {
}
}
- assertTrue(exceptionForwarded.get());
+ assertThat(exceptionForwarded.get()).isTrue();
Review Comment:
Thanks for catching this!
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/AsynchronousFileIOChannelTest.java:
##########
@@ -308,8 +308,8 @@ public void requestFailed(MemorySegment buffer, IOException
e) {
writer.close();
- assertEquals(NUM_BLOCKS, callbackCounter.get());
- assertFalse(exceptionOccurred.get());
+ assertThat(callbackCounter.get()).isEqualTo(NUM_BLOCKS);
+ assertThat(exceptionOccurred.get()).isFalse();
Review Comment:
Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
