zhuzhurk commented on code in PR #23167:
URL: https://github.com/apache/flink/pull/23167#discussion_r1294267273
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java:
##########
@@ -94,6 +101,12 @@ public ExecutionTimeBasedSlowTaskDetector(Configuration
configuration) {
this.baselineMultiplier);
}
+ public ExecutionTimeBasedSlowTaskDetector(
+ Configuration configuration, FatalErrorHandler fatalErrorHandler) {
+ this(configuration);
+ this.fatalErrorHandler = fatalErrorHandler;
Review Comment:
Better to checkNotNull
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java:
##########
@@ -94,6 +101,12 @@ public ExecutionTimeBasedSlowTaskDetector(Configuration
configuration) {
this.baselineMultiplier);
}
+ public ExecutionTimeBasedSlowTaskDetector(
Review Comment:
Should be annotated with `@VisibleForTesting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
