qinf commented on code in PR #23191:
URL: https://github.com/apache/flink/pull/23191#discussion_r1290869793
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -305,23 +305,26 @@ public void addShipFiles(List<File> shipFiles) {
private void addShipArchives(List<File> shipArchives) {
checkArgument(
isArchiveOnlyIncludedInShipArchiveFiles(shipArchives),
- "Non-archive files are included.");
+ "Directories or non-archive files are included.");
this.shipArchives.addAll(shipArchives);
}
private static boolean isArchiveOnlyIncludedInShipArchiveFiles(List<File>
shipFiles) {
- return shipFiles.stream()
- .filter(File::isFile)
- .map(File::getName)
- .map(String::toLowerCase)
- .allMatch(
- name ->
- name.endsWith(".tar.gz")
- || name.endsWith(".tar")
- || name.endsWith(".tgz")
- || name.endsWith(".dst")
- || name.endsWith(".jar")
- || name.endsWith(".zip"));
+ long archivedFileCount =
+ shipFiles.stream()
+ .filter(File::isFile)
+ .map(File::getName)
+ .map(String::toLowerCase)
+ .filter(
+ name ->
+ name.endsWith(".tar.gz")
+ || name.endsWith(".tar")
+ || name.endsWith(".tgz")
+ || name.endsWith(".dst")
+ || name.endsWith(".jar")
+ || name.endsWith(".zip"))
Review Comment:
@RocMarshal The archive types have not changed for over 2 years, maybe it is
a good time to do this when there is a new archive type need to add here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
