[
https://issues.apache.org/jira/browse/FLINK-32761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751409#comment-17751409
]
Roman Khachatryan commented on FLINK-32761:
-------------------------------------------
Good point [~Feifan Wang], I think it makes sense.
> Use UUID based on PhysicalStateHandleID as SharedStateRegistryKey
> ChangelogStateHandleStreamImpl
> ------------------------------------------------------------------------------------------------
>
> Key: FLINK-32761
> URL: https://issues.apache.org/jira/browse/FLINK-32761
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / State Backends
> Reporter: Feifan Wang
> Priority: Major
> Labels: pull-request-available
>
> _ChangelogStateHandleStreamImpl#getKey()_ use
> _System.identityHashCode(stateHandle)_ as _SharedStateRegistryKey_ while
> stateHandle is not _FileStateHandle_ or {_}ByteStreamStateHandle{_}. That can
> easily lead to collision, although from the current code path, it only
> affects the test code.
> In FLINK-29913 , we use UUID based on PhysicalStateHandleID as
> SharedStateRegistryKey in IncrementalRemoteKeyedStateHandle, we can reuse
> this method in ChangelogStateHandleStreamImpl.
>
> WDYT [~roman] ?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
