afedulov commented on code in PR #637:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/637#discussion_r1279737169
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SnapshotObserver.java:
##########
@@ -124,14 +159,78 @@ private void
observeTriggeredSavepoint(FlinkResourceContext<CR> ctx, String jobI
savepointFetchResult.getLocation(),
savepointInfo.getTriggerType(),
savepointInfo.getFormatType(),
- SavepointTriggerType.MANUAL ==
savepointInfo.getTriggerType()
+ SnapshotTriggerType.MANUAL ==
savepointInfo.getTriggerType()
?
resource.getSpec().getJob().getSavepointTriggerNonce()
: null);
-
ReconciliationUtils.updateLastReconciledSavepointTriggerNonce(savepointInfo,
resource);
+ ReconciliationUtils.updateLastReconciledSnapshotTriggerNonce(
+ savepointInfo, resource, SAVEPOINT);
savepointInfo.updateLastSavepoint(savepoint);
}
+ /**
+ * Observe the status of triggered checkpoints.
+ *
+ * @param ctx Resource context.
+ * @param jobID the jobID of the observed job.
+ */
+ private void observeTriggeredCheckpoint(FlinkResourceContext<CR> ctx,
String jobID) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
