dawidwys commented on code in PR #23084:
URL: https://github.com/apache/flink/pull/23084#discussion_r1275887773


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/catalog/UnknownCatalogTest.java:
##########
@@ -55,6 +56,52 @@ public class UnknownCatalogTest {
     public static final ResolvedSchema EXPECTED_SCHEMA =
             ResolvedSchema.of(Column.physical("i", INT()), 
Column.physical("s", STRING()));
 
+    public static final ResolvedSchema CURRENT_TIMESTAMP_EXPECTED_SCHEMA =
+            ResolvedSchema.of(Column.physical("CURRENT_TIMESTAMP", 
TIMESTAMP_LTZ(3).notNull()));
+
+    @Test
+    public void testUnsetCatalogWithSelect1() throws Exception {

Review Comment:
   I think this does not add any test coverage, imo. There is no object 
resolution here. As it should be not expensive, it's up to you if you want to 
leave it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to