luoyuxia commented on code in PR #23075:
URL: https://github.com/apache/flink/pull/23075#discussion_r1274747812
##########
docs/content/docs/dev/table/sql/insert.md:
##########
@@ -208,7 +208,9 @@ column_list:
**COLUMN LIST**
Given a table T(a INT, b INT, c INT), Flink supports INSERT INTO T(c, b)
SELECT x, y FROM S. The expectation is
-that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+For the connector developers who want to avoid overwriting non-target columns
with null values when processing partial column updates,
+this user specified target column list can be found from the {{< gh_link
file="flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/DynamicTableSink.java"
name="DynamicTableSink$Context.getTargetColumns()" >}}.
Review Comment:
nit
```suggestion
this user-specified target column list can be found from the {{< gh_link
file="flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/DynamicTableSink.java"
name="DynamicTableSink$Context.getTargetColumns()" >}}.
```
##########
docs/content/docs/dev/table/sql/insert.md:
##########
@@ -208,7 +208,9 @@ column_list:
**COLUMN LIST**
Given a table T(a INT, b INT, c INT), Flink supports INSERT INTO T(c, b)
SELECT x, y FROM S. The expectation is
-that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+For the connector developers who want to avoid overwriting non-target columns
with null values when processing partial column updates,
Review Comment:
Also, I'm wondering whether it's more clear to break the line in here since
these lines are more likely to say other things.
##########
docs/content/docs/dev/table/sql/insert.md:
##########
@@ -208,7 +208,9 @@ column_list:
**COLUMN LIST**
Given a table T(a INT, b INT, c INT), Flink supports INSERT INTO T(c, b)
SELECT x, y FROM S. The expectation is
-that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+For the connector developers who want to avoid overwriting non-target columns
with null values when processing partial column updates,
Review Comment:
It seems like we miss how the connector devs can avoid it? may be some like:
```
For the connector .... when processing partial column updates, they can find
the user-specified target column list and only update the target columns.
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
