patricklucas commented on code in PR #22987:
URL: https://github.com/apache/flink/pull/22987#discussion_r1272124153
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##########
@@ -131,6 +133,11 @@ public class RestClient implements AutoCloseableAsync {
private final String urlPrefix;
+ // Used to track unresolved request futures in case they need to be
resolved when the client is
+ // closed
+ private final Map<CompletableFuture<Channel>, Void> responseChannelFutures
=
+ Collections.synchronizedMap(new IdentityHashMap<>());
Review Comment:
I had gone with `IdentityHashMap` since we want to maintain references to
the actual future objects, however since `CompletableFuture`'s `equals` and
`hashCode` just delegate to `Object`, the behavior is the same. I'll make the
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
