leonardBang commented on code in PR #23036:
URL: https://github.com/apache/flink/pull/23036#discussion_r1271314112
##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/internal/StreamTableEnvironmentImpl.java:
##########
@@ -115,8 +115,10 @@ public static StreamTableEnvironment create(
new ResourceManager(settings.getConfiguration(),
userClassLoader);
final ModuleManager moduleManager = new ModuleManager();
final CatalogStore catalogStore =
- TableFactoryUtil.findAndCreateCatalogStore(
- settings.getConfiguration(), userClassLoader);
+ settings.getCatalogStore() != null
Review Comment:
In this branch ,who will take care the lifecycle of CatalogStoreFactory, i.e
open/close connection resources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
