lsyldliu commented on code in PR #23035:
URL: https://github.com/apache/flink/pull/23035#discussion_r1271222278
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java:
##########
@@ -71,12 +72,25 @@ public DynamicTableSourceSpec(
private DynamicTableSource getTableSource(FlinkContext context,
FlinkTypeFactory typeFactory) {
if (tableSource == null) {
- final DynamicTableSourceFactory factory =
+ DynamicTableSourceFactory factory =
context.getModuleManager()
.getFactory(Module::getTableSourceFactory)
.orElse(null);
ResolvedCatalogTable resolvedCatalogTable =
contextResolvedTable.getResolvedTable();
+ if (factory == null) {
Review Comment:
Yes, this change proposed is to fix the hive `testQueries` and
`testAdditionalQueries` test. I have split this change into a separated commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
