LadyForest commented on code in PR #22593:
URL: https://github.com/apache/flink/pull/22593#discussion_r1269392023
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java:
##########
@@ -71,20 +75,36 @@
producedTransformations =
StreamExecChangelogNormalize.CHANGELOG_NORMALIZE_TRANSFORMATION,
minPlanVersion = FlinkVersion.v1_15,
minStateVersion = FlinkVersion.v1_15)
+@ExecNodeMetadata(
+ name = "stream-exec-changelog-normalize",
+ version = 2,
Review Comment:
> Are we still able to deserialize 1.15 literals with this change?
I suppose so. I adapted the test `TransformationsTest#testUidFlink1_15` to
verify the change. The test deserialized the serialized plan using Flink v1.15,
where numbers are serialized as string literals.
> Also the SARG values cannot be null anymore?
Sorry, I'm a bit confused on this point. Did you find any incompatibilities?
AFAIK, the changes made on `RexNodeJsonSerializer` does not aim to change the
processing logic for `SARG`. You can check `RexNodeJsonSerdeTest` and
`SargJsonPlanITCase` for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
