yunfengzhou-hub commented on code in PR #22931:
URL: https://github.com/apache/flink/pull/22931#discussion_r1267760838
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -2079,11 +2149,19 @@ private final class ScheduledTrigger implements
Runnable {
@Override
public void run() {
+ long currentTime = clock.relativeTimeMillis();
+ if (lastCheckpointTriggeringRelativeTime != NO_CHECKPOINT
+ && currentTime - lastCheckpointTriggeringRelativeTime <
baseInterval) {
Review Comment:
With the current implementation in which
`lastCheckpointTriggeringRelativeTime` could be `Long.MIN_VALUE`, `currentTime
- lastCheckpointTriggeringRelativeTime` could cause stack overflow. Thus I
treat `Long.MIN_VALUE` specially here. This would be resolved after I replace
the default value with 0 or -1 according to the previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
