hackergin commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1259408171
########## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogStoreTest.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import org.apache.flink.configuration.Configuration; + +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.AssertionsForClassTypes.assertThat; + +/** Test for {@link GenericInMemoryCatalogStore}. */ +public class GenericInMemoryCatalogStoreTest { + + @Test + void testStoreAndGet() { + CatalogStore catalogStore = new GenericInMemoryCatalogStore(); + catalogStore.open(); + + catalogStore.storeCatalog( + "catalog1", CatalogDescriptor.of("catalog1", new Configuration())); + assertThat(catalogStore.getCatalog("catalog1").isPresent()).isTrue(); + assertThat(catalogStore.contains("catalog1")).isTrue(); + + catalogStore.removeCatalog("catalog1", true); + assertThat(catalogStore.contains("catalog1")).isFalse(); + + catalogStore.close(); Review Comment: I think this may depend on the specific implementation of CatalogStoreFactory. In GenericInMemoryCatalogStoreFactory, it’s close methods do not handle any logic, just like InMemoryCatalog. So even after closing, you can still continue to use the getCatalog method. However, based on the current usage flow of CatalogStore, this situation is unlikely to occur. I also tried to create a CatalogStoreFactory that cannot continue to use getCatalog after closing, but I think it may be redundant and this process should be controlled by the specific implementation logic. Therefore, I did not add related tests in this PullRequest. What do you think? ########## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogStoreTest.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import org.apache.flink.configuration.Configuration; + +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.AssertionsForClassTypes.assertThat; + +/** Test for {@link GenericInMemoryCatalogStore}. */ +public class GenericInMemoryCatalogStoreTest { + + @Test + void testStoreAndGet() { + CatalogStore catalogStore = new GenericInMemoryCatalogStore(); + catalogStore.open(); + + catalogStore.storeCatalog( + "catalog1", CatalogDescriptor.of("catalog1", new Configuration())); + assertThat(catalogStore.getCatalog("catalog1").isPresent()).isTrue(); + assertThat(catalogStore.contains("catalog1")).isTrue(); + + catalogStore.removeCatalog("catalog1", true); + assertThat(catalogStore.contains("catalog1")).isFalse(); + + catalogStore.close(); Review Comment: I think this may depend on the specific implementation of CatalogStoreFactory. In GenericInMemoryCatalogStoreFactory, it’s close methods do not handle any logic, just like InMemoryCatalog. So even after closing, you can still continue to use the getCatalog method. However, based on the current usage flow of CatalogStore, this situation is unlikely to occur. I also tried to create a CatalogStoreFactory that cannot continue to use getCatalog after closing, but I think it may be redundant and this process should be controlled by the specific implementation logic. Therefore, I did not add related tests in this PullRequest. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
