[ 
https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739787#comment-17739787
 ] 

Tzu-Li (Gordon) Tai edited comment on FLINK-32455 at 7/4/23 4:36 AM:
---------------------------------------------------------------------

One (quicker) fix for now might be to make a copy of the original 
{{TypeSerializerUpgradeTestBase}} to the Kafka connector, and only afterwards 
introduce a proper public-facing test utility in {{apache/flink}} and only then 
migration the Kafka connector test code to move to that.


was (Author: tzulitai):
One (quick) fix for now might be to make a copy of the original 
{{TypeSerializerUpgradeTestBase}} to the Kafka connector, and only afterwards 
introduce a proper public-facing test utility in {{apache/flink}} and only then 
migration the Kafka connector test code to move to that.

> Breaking change in TypeSerializerUpgradeTestBase prevents 
> flink-connector-kafka from building against 1.18-SNAPSHOT
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-32455
>                 URL: https://issues.apache.org/jira/browse/FLINK-32455
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Connectors / Kafka, Test Infrastructure
>    Affects Versions: 1.18.0
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>             Fix For: 1.18.0
>
>
> FLINK-27518 introduced a breaking signature change to the abstract class 
> {{TypeSerializerUpgradeTestBase}}, specifically the abstract 
> {{createTestSpecifications}} method signature was changed. This breaks 
> downstream test code in externalized connector repos, e.g. 
> flink-connector-kafka's {{KafkaSerializerUpgradeTest}}
> Moreover, {{fink-migration-test-utils}} needs to be transitively pulled in by 
> downstream test code that depends on flink-core test-jar.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to