1996fanrui commented on code in PR #22852:
URL: https://github.com/apache/flink/pull/22852#discussion_r1241046599
##########
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##########
@@ -131,6 +138,101 @@ void testWatermarkAlignmentWithTwoGroups() throws
Exception {
}
}
+ @Test
+ @Timeout(5)
+ void testWatermarkAggregatorBenchmark() {
Review Comment:
Added a unit test about benchmark:
- The duration of this test based on master branch is 1 min 44s
- The duration of this test based on master branch with this PR is 469ms
The performance is improved by almost 200 times.
<img width="905" alt="image"
src="https://github.com/apache/flink/assets/38427477/b4346d73-50a9-4d0f-8d7e-398220f7c612";>
<img width="1024" alt="image"
src="https://github.com/apache/flink/assets/38427477/47ffcb55-1c57-40b9-bc12-9e3fb88e4da8";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
