zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1235147823
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java:
##########
@@ -359,11 +357,12 @@ IncrementalRemoteKeyedStateHandle copy() {
stateHandleId);
}
- /** Create a unique key to register one of our shared state handles. */
+ /** Create a unique key based on physical id to register one of our shared
state handles. */
@VisibleForTesting
- public SharedStateRegistryKey
createSharedStateRegistryKeyFromFileName(StateHandleID shId) {
+ public SharedStateRegistryKey
createSharedStateRegistryKey(StreamStateHandle handle) {
+ String keyString = handle.getStreamStateHandleID().getKeyString();
return new SharedStateRegistryKey(
- String.valueOf(backendIdentifier) + '-' + keyGroupRange, shId);
+
UUID.nameUUIDFromBytes(keyString.getBytes(StandardCharsets.UTF_8)).toString());
Review Comment:
Yes, key strings tend to be longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
