zentol commented on code in PR #22829:
URL: https://github.com/apache/flink/pull/22829#discussion_r1235011575
##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionTest.java:
##########
@@ -438,13 +441,20 @@ void testLeaderShouldBeCorrectedWhenOverwritten() throws
Exception {
boolean dataWritten = false;
final String connectionInformationPath =
- leaderElectionDriver.getConnectionInformationPath();
+
ZooKeeperUtils.generateConnectionInformationPath(CONTENDER_ID);
while (!dataWritten) {
anotherCuratorFrameworkWrapper
.asCuratorFramework()
.delete()
.forPath(connectionInformationPath);
+ System.out.println(
Review Comment:
?
##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionTest.java:
##########
@@ -396,17 +391,22 @@ void testLeaderChangeWriteLeaderInformationOnlyOnce()
throws Exception {
* Tests that the current leader is notified when his leader connection
information in ZooKeeper
* are overwritten. The leader must re-establish the correct leader
connection information in
* ZooKeeper.
+ *
+ * @deprecated This test verifies the change leader information event
handling without the
+ * {@link DefaultLeaderElectionService}. Essentially, it was testing
the {@link
+ * TestingLeaderElectionEventHandler} implementation.
Review Comment:
should we drop it then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
