hanyuzheng7 commented on code in PR #22717: URL: https://github.com/apache/flink/pull/22717#discussion_r1228736983
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ########## @@ -479,4 +480,82 @@ private Stream<TestSetSpec> arrayUnionTestCases() { "Invalid input arguments. Expected signatures are:\n" + "ARRAY_UNION(<COMMON>, <COMMON>)")); } + + private Stream<TestSetSpec> arrayConcatTestCases() { + return Stream.of( + TestSetSpec.forFunction(BuiltInFunctionDefinitions.ARRAY_CONCAT) + .onFieldsWithData( + new Integer[] {1, 2, null}, + null, + new Row[] { + Row.of(true, LocalDate.of(2022, 4, 20)), + Row.of(true, LocalDate.of(1990, 10, 14)), + null + }, + 1, + new Integer[][] {{1}}, + new String[] {"123"}) + .andDataTypes( + DataTypes.ARRAY(DataTypes.INT()), + DataTypes.ARRAY(DataTypes.INT()), + DataTypes.ARRAY( + DataTypes.ROW(DataTypes.BOOLEAN(), DataTypes.DATE())), + DataTypes.INT(), Review Comment: you can see other methods test cases in this file, some one use DataTypes.INT() when the input doesn't contain nulls -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org